Add a new pass to generate column-wise control overlay #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yu-Zhewen
force-pushed
the
zhewen_ctrl_overlay
branch
from
a9de2c6 to
bc0a1b9
Compare
jtuyls
requested changes
Jan 8, 2025
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIEGenerateColumnControlOverlay.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIEGenerateColumnControlOverlay.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIEGenerateColumnControlOverlay.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIEGenerateColumnControlOverlay.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIEGenerateColumnControlOverlay.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIEGenerateColumnControlOverlay.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIEGenerateColumnControlOverlay.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIEGenerateColumnControlOverlay.cpp
Outdated
Show resolved
Hide resolved
Yu-Zhewen
commented
Jan 8, 2025
| @@ -267,7 +267,7 @@ LogicalResult configureStreamSwitch(const AMDAIEDeviceModel &deviceModel, | |||
| const TileLoc &tileLoc, | |||
| const std::vector<Connect> &connects) { | |||
| auto devInst = const_cast<XAie_DevInst *>(&deviceModel.devInst); | |||
| // FIXME hack for TCT routing | |||
| // mlir-air legacy, hack for TCT routing | |||
There was a problem hiding this comment.
Unfortunately, since the new pass operates on AMDAIE::TileOp and FlowOp, this hack cannot be removed for tests using AIR.
Yu-Zhewen
changed the title
Yu-Zhewen
requested review from
makslevental,
MaheshRavishankar,
nirvedhmeshram,
yzhang93 and
Abhishek-Varma
as code owners
jtuyls
reviewed
Jan 9, 2025
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIEGenerateColumnControlOverlay.cpp
Outdated
Show resolved
Hide resolved
jtuyls
reviewed
Jan 9, 2025
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIEGenerateColumnControlOverlay.cpp
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from Xilinx/mlir-aie#1705.
Introduces a new pass to automatically insert the following two groups of flows:
route-shim-to-tct, circuit flows from shimCTRLto shimSOUTHports, for sending TCTs.route-shim-to-tile-ctrl, packet flows between shimDMAto shim/mem/compute tileCTRLports, for sending control packets.